Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1

audit: Port audit_options non-strict rules to rubocop and add tests

3 files changed, 33 insertions, 6 deletions

diff --git a/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb b/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
index a775b0b17..563f7ad4b 100644
--- a/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/bottle_block_cop_spec.rb
@@ -18,7 +18,7 @@ describe RuboCop::Cop::FormulaAuditStrict::BottleBlock do
         end
       EOS
 
-      expected_offenses = [{  message: "Use rebuild instead of revision in bottle block",
+      expected_offenses = [{  message: described_class::MSG,
                               severity: :convention,
                               line: 5,
                               column: 4,
diff --git a/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb b/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
index c3175509a..4fbab6c9e 100644
--- a/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/conflicts_cop_spec.rb
@@ -16,11 +16,7 @@ describe RuboCop::Cop::FormulaAudit::Conflicts do
         end
       EOS
 
-      msg = <<-EOS.undent
-            Versioned formulae should not use `conflicts_with`.
-            Use `keg_only :versioned_formula` instead.
-      EOS
-      expected_offenses = [{  message: msg,
+      expected_offenses = [{  message: described_class::MSG,
                               severity: :convention,
                               line: 3,
                               column: 2,
diff --git a/Library/Homebrew/test/rubocops/options_cop_spec.rb b/Library/Homebrew/test/rubocops/options_cop_spec.rb
new file mode 100644
index 000000000..0ed3a9741
--- /dev/null
+++ b/Library/Homebrew/test/rubocops/options_cop_spec.rb
@@ -0,0 +1,31 @@
+require "rubocop"
+require "rubocop/rspec/support"
+require_relative "../../extend/string"
+require_relative "../../rubocops/options_cop"
+
+describe RuboCop::Cop::FormulaAudit::Options do
+  subject(:cop) { described_class.new }
+
+  context "When auditing options" do
+    it "32-bit" do
+      source = <<-EOS.undent
+        class Foo < Formula
+          url 'http://example.com/foo-1.0.tgz'
+          option "32-bit", "with 32-bit"
+        end
+      EOS
+
+      expected_offenses = [{  message: described_class::DEPRECATION_MSG,
+                              severity: :convention,
+                              line: 3,
+                              column: 10,
+                              source: source }]
+
+      inspect_source(cop, source)
+
+      expected_offenses.zip(cop.offenses).each do |expected, actual|
+        expect_offense(expected, actual)
+      end
+    end
+  end
+end