aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/test/rubocops
diff options
context:
space:
mode:
authorGautham Goli2017-08-14 01:09:06 +0530
committerGautham Goli2017-08-14 01:09:06 +0530
commit7dfe09ccae5b1a8309326e5a5cb3172fbcd795d3 (patch)
tree56aacffccfa1429c195837f7ea2f75d3c0c2b1f0 /Library/Homebrew/test/rubocops
parenta73c29fef21ccb7f45243500f04f1ed9965fdf38 (diff)
downloadbrew-7dfe09ccae5b1a8309326e5a5cb3172fbcd795d3.tar.bz2
Add tests for fileUtils call in system
Diffstat (limited to 'Library/Homebrew/test/rubocops')
-rw-r--r--Library/Homebrew/test/rubocops/lines_cop_spec.rb21
1 files changed, 21 insertions, 0 deletions
diff --git a/Library/Homebrew/test/rubocops/lines_cop_spec.rb b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
index 203f8a7d9..1af5d2e72 100644
--- a/Library/Homebrew/test/rubocops/lines_cop_spec.rb
+++ b/Library/Homebrew/test/rubocops/lines_cop_spec.rb
@@ -575,6 +575,27 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
expect_offense(expected, actual)
end
end
+ it "with system call to fileUtils Method" do
+ source = <<-EOS.undent
+ class Foo < Formula
+ desc "foo"
+ url 'http://example.com/foo-1.0.tgz'
+ system "mkdir", "foo"
+ end
+ EOS
+
+ expected_offenses = [{ message: "Use the `mkdir` Ruby method instead of `system \"mkdir\", \"foo\"`",
+ severity: :convention,
+ line: 4,
+ column: 10,
+ source: source }]
+
+ inspect_source(cop, source)
+
+ expected_offenses.zip(cop.offenses).each do |expected, actual|
+ expect_offense(expected, actual)
+ end
+ end
end
def expect_offense(expected, actual)
expect(actual.message).to eq(expected[:message])