diff options
| author | eregon | 2011-03-20 22:37:25 +0100 |
|---|---|---|
| committer | Adam Vandenberg | 2011-03-20 19:12:29 -0700 |
| commit | b6506fb4ea02fbffaa047df46effed1f30b52ff6 (patch) | |
| tree | 70ed22fdfb129bcd516679abfdf29d56a3898453 /Library/Homebrew/formula.rb | |
| parent | aefb14404876efd6b2a16626d52a8302a7aecadb (diff) | |
| download | brew-b6506fb4ea02fbffaa047df46effed1f30b52ff6.tar.bz2 | |
use Module#const_get instead of eval
* may be a problem if the constant is scoped (like A::B), but this is not the case
(const.split('::').inject(Object) { |c, part| c.const_get part } would solve that)
* this was noticed in a comment of 9afc85ad but it has disappeared
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Diffstat (limited to 'Library/Homebrew/formula.rb')
| -rw-r--r-- | Library/Homebrew/formula.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index e394d0f5c..dd4e03261 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -378,7 +378,7 @@ class Formula begin klass_name = self.class_s(name) - klass = eval(klass_name) + klass = Object.const_get klass_name rescue NameError # TODO really this text should be encoded into the exception # and only shown if the UI deems it correct to show it |