aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/extend
diff options
context:
space:
mode:
authorBrandon Black2012-07-28 11:36:08 -0700
committerMax Howell2012-08-06 22:02:38 -0400
commitbcde6432f3b7e42870ee4b3ee7a6eb06021c62e7 (patch)
tree9fe9a7a34007810034d4783b584062c47ce7d1b0 /Library/Homebrew/extend
parent1f622843844e5d52d598c2f8be360a13416454c9 (diff)
downloadbrew-bcde6432f3b7e42870ee4b3ee7a6eb06021c62e7.tar.bz2
Fix issues with writable? detection in brew doctor
Closes Homebrew/homebrew#13689. Signed-off-by: Max Howell <mxcl@me.com> There are subtle distinctions between writable? and writable_real? we don't understand precisely why we need this, but it fixes the bugs :/
Diffstat (limited to 'Library/Homebrew/extend')
-rw-r--r--Library/Homebrew/extend/pathname.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/Library/Homebrew/extend/pathname.rb b/Library/Homebrew/extend/pathname.rb
index 14d902880..da0f641cb 100644
--- a/Library/Homebrew/extend/pathname.rb
+++ b/Library/Homebrew/extend/pathname.rb
@@ -353,7 +353,7 @@ class Pathname
To list all files that would be deleted:
brew link -n formula_name
EOS
- elsif !dirname.writable?
+ elsif !dirname.writable_real?
raise <<-EOS.undent
Could not symlink file: #{src.expand_path}
#{dirname} is not writable. You should change its permissions.
@@ -375,7 +375,7 @@ class Pathname
def ensure_writable
saved_perms = nil
- unless writable?
+ unless writable_real?
saved_perms = stat.mode
chmod 0644
end