diff options
| author | Jack Nagel | 2013-06-27 01:18:32 -0500 | 
|---|---|---|
| committer | Jack Nagel | 2013-06-27 01:18:45 -0500 | 
| commit | 10949ad75deaca284300f4db0f392d5a6dba77e8 (patch) | |
| tree | 476698dfc253ca760cc4ac03d3afb5f51934f46e /Library/Homebrew/download_strategy.rb | |
| parent | ad291d7f06acefad08453d781b3bbc70edc71238 (diff) | |
| download | brew-10949ad75deaca284300f4db0f392d5a6dba77e8.tar.bz2 | |
Fix some #eql? correctness issues
The implementation of #eql? and #hash should ensure that if a.eql?(b),
then a.hash == b.hash, but #eql? itself should not *depend* on #hash.
For example, given
  class Thingy
    def eql?
      instance_of?(other.class) && hash == other.hash
    end
    def hash
      [name, *tags].hash
    end
  end
if #hash produces a collision for different values of [name, *tags], two
Thingy objects will appear to be eql?, even though this is not the case.
Instead, #eql? should depend on the equality of name and tags directly.
Diffstat (limited to 'Library/Homebrew/download_strategy.rb')
0 files changed, 0 insertions, 0 deletions
