diff options
| author | ilovezfs | 2017-09-25 23:01:36 -0700 |
|---|---|---|
| committer | ilovezfs | 2017-09-25 23:03:19 -0700 |
| commit | feda0242be174c63925a7e982cc05d6e9748acd8 (patch) | |
| tree | ceda202ae04c5769d86a0b69b407df7d229365be /Library/Homebrew/dev-cmd | |
| parent | 6098998674389638dc1831d2ee17baf54d99e6c6 (diff) | |
| download | brew-feda0242be174c63925a7e982cc05d6e9748acd8.tar.bz2 | |
bump-formula-pr: fix duplicates check
`return unless pull_requests && !pull_requests.empty?` and
`return unless pull_requests&.empty?` are not equivalent.
Diffstat (limited to 'Library/Homebrew/dev-cmd')
| -rw-r--r-- | Library/Homebrew/dev-cmd/bump-formula-pr.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Library/Homebrew/dev-cmd/bump-formula-pr.rb b/Library/Homebrew/dev-cmd/bump-formula-pr.rb index 21abed7d9..87d8274cc 100644 --- a/Library/Homebrew/dev-cmd/bump-formula-pr.rb +++ b/Library/Homebrew/dev-cmd/bump-formula-pr.rb @@ -89,7 +89,8 @@ module Homebrew def check_for_duplicate_pull_requests(formula) pull_requests = fetch_pull_requests(formula) - return unless pull_requests&.empty? + return unless pull_requests + return if pull_requests.empty? duplicates_message = <<-EOS.undent These open pull requests may be duplicates: #{pull_requests.map { |pr| "#{pr["title"]} #{pr["html_url"]}" }.join("\n")} |