aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd
diff options
context:
space:
mode:
authorMike McQuaid2017-03-05 11:42:59 +0100
committerMike McQuaid2017-03-05 11:42:59 +0100
commite26cf3a83f5b955c7d004a5c4e8f2668bbf097de (patch)
treef0ce24f7416620ce53069bf1d71fbbef2f7d6e91 /Library/Homebrew/dev-cmd
parent6d42e2a527c8c76d9d35f940c35101f6b42c693e (diff)
downloadbrew-e26cf3a83f5b955c7d004a5c4e8f2668bbf097de.tar.bz2
Don't check Subversion HTTPS pre-Sierra.
The system Subversion doesn't handle new certificate authorities (e.g. Let's Encrypt) well enough for this check to be useful.
Diffstat (limited to 'Library/Homebrew/dev-cmd')
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index a8c18f7b6..f620bbe16 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -680,8 +680,6 @@ class FormulaAuditor
return unless @online
- # The system Curl is too old and unreliable with HTTPS homepages on
- # Yosemite and below.
return unless DevelopmentTools.curl_handles_most_https_homepages?
if http_content_problem = FormulaAuditor.check_http_content(homepage,
user_agents: [:browser, :default])
@@ -1571,6 +1569,7 @@ class ResourceAuditor
problem "The URL #{url} is not a valid git URL"
end
elsif strategy <= SubversionDownloadStrategy
+ next unless DevelopmentTools.subversion_handles_most_https_certificates?
unless Utils.svn_remote_exists url
problem "The URL #{url} is not a valid svn URL"
end