diff options
| author | Gautham Goli | 2017-06-01 00:57:24 +0530 |
|---|---|---|
| committer | Gautham Goli | 2017-06-16 19:45:16 +0530 |
| commit | 4d7a98341556614818223060ca94413b17e3d1e6 (patch) | |
| tree | 16562b6d5e4f34ed3184bbe2ebf90e0e76d3893f /Library/Homebrew/dev-cmd | |
| parent | 3b376bfa2f8d3e61dc1164304d4f8d64de6e6014 (diff) | |
| download | brew-4d7a98341556614818223060ca94413b17e3d1e6.tar.bz2 | |
audit: Port audit_checksum method to rubocop and add tests
Diffstat (limited to 'Library/Homebrew/dev-cmd')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 0d9a630fd..a6c71f795 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -1246,7 +1246,6 @@ class ResourceAuditor def audit audit_version - audit_checksum audit_download_strategy audit_urls self @@ -1273,28 +1272,6 @@ class ResourceAuditor problem "version #{version} should not end with an underline and a number" end - def audit_checksum - return unless checksum - - case checksum.hash_type - when :md5 - problem "MD5 checksums are deprecated, please use SHA256" - return - when :sha1 - problem "SHA1 checksums are deprecated, please use SHA256" - return - when :sha256 then len = 64 - end - - if checksum.empty? - problem "#{checksum.hash_type} is empty" - else - problem "#{checksum.hash_type} should be #{len} characters" unless checksum.hexdigest.length == len - problem "#{checksum.hash_type} contains invalid characters" unless checksum.hexdigest =~ /^[a-fA-F0-9]+$/ - problem "#{checksum.hash_type} should be lowercase" unless checksum.hexdigest == checksum.hexdigest.downcase - end - end - def audit_download_strategy if url =~ %r{^(cvs|bzr|hg|fossil)://} || url =~ %r{^(svn)\+http://} problem "Use of the #{$&} scheme is deprecated, pass `:using => :#{Regexp.last_match(1)}` instead" |