diff options
| author | Mike McQuaid | 2017-02-21 18:50:07 +0000 |
|---|---|---|
| committer | Mike McQuaid | 2017-02-21 18:50:07 +0000 |
| commit | 2f42dfc68a7c3cfdb2d364fc98dff67fea89e78e (patch) | |
| tree | fd58cea0678c38c062fee7e7ee75e687265763d6 /Library/Homebrew/dev-cmd | |
| parent | ed7290abb4b5a6820c30cd10b141a7713d932fd6 (diff) | |
| download | brew-2f42dfc68a7c3cfdb2d364fc98dff67fea89e78e.tar.bz2 | |
audit: fix revision should be removed.
Regression introduced in #1754 which meant that (due to storing the
current formula revision in `attributes_map`) `stable_revisions.empty?`
would never be `true`.
Diffstat (limited to 'Library/Homebrew/dev-cmd')
| -rw-r--r-- | Library/Homebrew/dev-cmd/audit.rb | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 9da5d28b4..d9c4bcddb 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -816,10 +816,12 @@ class FormulaAuditor return if formula.revision.zero? if formula.stable - revision_map = attributes_map[:revision][:stable] - stable_revisions = revision_map[formula.stable.version] if revision_map - if !stable_revisions || stable_revisions.empty? - problem "'revision #{formula.revision}' should be removed" + if revision_map = attributes_map[:revision][:stable] + stable_revisions = revision_map[formula.stable.version] + stable_revisions -= [formula.revision] + if stable_revisions.empty? + problem "'revision #{formula.revision}' should be removed" + end end else # head/devel-only formula problem "'revision #{formula.revision}' should be removed" |