Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars

rubocop: don’t allow special global variables.

3 files changed, 4 insertions, 4 deletions

diff --git a/Library/Homebrew/dev-cmd/bump-formula-pr.rb b/Library/Homebrew/dev-cmd/bump-formula-pr.rb
index 684843d0d..586eec47c 100644
--- a/Library/Homebrew/dev-cmd/bump-formula-pr.rb
+++ b/Library/Homebrew/dev-cmd/bump-formula-pr.rb
@@ -265,10 +265,10 @@ module Homebrew
       failed_audit = false
       if ARGV.include? "--strict"
         system HOMEBREW_BREW_FILE, "audit", "--strict", formula.path
-        failed_audit = !$?.success?
+        failed_audit = !$CHILD_STATUS.success?
       elsif ARGV.include? "--audit"
         system HOMEBREW_BREW_FILE, "audit", formula.path
-        failed_audit = !$?.success?
+        failed_audit = !$CHILD_STATUS.success?
       end
       if failed_audit
         formula.path.atomic_write(backup_file)
diff --git a/Library/Homebrew/dev-cmd/pull.rb b/Library/Homebrew/dev-cmd/pull.rb
index 492898a47..c3e6c1452 100644
--- a/Library/Homebrew/dev-cmd/pull.rb
+++ b/Library/Homebrew/dev-cmd/pull.rb
@@ -459,7 +459,7 @@ module Homebrew
     def self.lookup(name)
       json = Utils.popen_read(HOMEBREW_BREW_FILE, "info", "--json=v1", name)
 
-      return nil unless $?.success?
+      return nil unless $CHILD_STATUS.success?
 
       Homebrew.force_utf8!(json)
       FormulaInfoFromJson.new(JSON.parse(json)[0])
diff --git a/Library/Homebrew/dev-cmd/tests.rb b/Library/Homebrew/dev-cmd/tests.rb
index 924629886..658f2e2f3 100644
--- a/Library/Homebrew/dev-cmd/tests.rb
+++ b/Library/Homebrew/dev-cmd/tests.rb
@@ -111,7 +111,7 @@ module Homebrew
         system "bundle", "exec", "rspec", *args, "--", *files
       end
 
-      return if $?.success?
+      return if $CHILD_STATUS.success?
       Homebrew.failed = true
     end
   end