aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/dev-cmd
diff options
context:
space:
mode:
authorMike McQuaid2017-05-29 10:06:04 +0100
committerMike McQuaid2017-05-29 10:06:04 +0100
commit224d2c21ca118cf91b21edc8fd19dacfeb2a3f3b (patch)
tree86891d7992d5f5fcb0dea212c3bb7924b0278437 /Library/Homebrew/dev-cmd
parentc2cb2c78680a36517603d8757d867eca1912924c (diff)
downloadbrew-224d2c21ca118cf91b21edc8fd19dacfeb2a3f3b.tar.bz2
update-test: improve no tags found messaging.
Currently you just get `Could not find start commit!` which is not as explicit as it could be.
Diffstat (limited to 'Library/Homebrew/dev-cmd')
-rw-r--r--Library/Homebrew/dev-cmd/update-test.rb14
1 files changed, 8 insertions, 6 deletions
diff --git a/Library/Homebrew/dev-cmd/update-test.rb b/Library/Homebrew/dev-cmd/update-test.rb
index add05bc7c..e65820750 100644
--- a/Library/Homebrew/dev-cmd/update-test.rb
+++ b/Library/Homebrew/dev-cmd/update-test.rb
@@ -33,14 +33,16 @@ module Homebrew
elsif date = ARGV.value("before")
Utils.popen_read("git", "rev-list", "-n1", "--before=#{date}", "origin/master").chomp
elsif ARGV.include?("--to-tag")
- previous_tag =
- Utils.popen_read("git", "tag", "--list", "--sort=-version:refname").lines[1]
- unless previous_tag
+ tags = Utils.popen_read("git", "tag", "--list", "--sort=-version:refname")
+ previous_tag = tags.lines[1]
+ previous_tag ||= begin
safe_system "git", "fetch", "--tags", "--depth=1"
- previous_tag =
- Utils.popen_read("git", "tag", "--list", "--sort=-version:refname").lines[1]
+ tags = Utils.popen_read("git", "tag", "--list", "--sort=-version:refname")
+ tags.lines[1]
end
- previous_tag.to_s.chomp
+ previous_tag = previous_tag.to_s.chomp
+ odie "Could not find previous tag in:\n#{tags}" if previous_tag.empty?
+ previous_tag
else
Utils.popen_read("git", "rev-parse", "origin/master").chomp
end