diff options
| author | Jack Nagel | 2014-07-30 21:46:22 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-07-30 21:46:22 -0500 |
| commit | fd86e6d636496c5221b8f93282a804e4bf3d21f1 (patch) | |
| tree | 182c55d47c08eef2ef128df62d5e5fdcb41cf45b /Library/Homebrew/dependency.rb | |
| parent | 5ccce044ca04b9586667b538f818d4a018f21fa7 (diff) | |
| download | brew-fd86e6d636496c5221b8f93282a804e4bf3d21f1.tar.bz2 | |
Remove confusing implicit options handling
This code is supposed to allow
depends_on "foo" => "with-bar"
to work when foo has only a "without-bar" option.
The options system was not designed to support this. Unfortunately, it
was bolted on anyway. The implementation is extremely difficult to
understand, and it only works for certain types of options, which is
confusing from a user's point of view. Luckily, no formulae in core or
the official taps rely on the behavior in order to function.
It is hindering progress in improving this code, so I am removing it.
Diffstat (limited to 'Library/Homebrew/dependency.rb')
| -rw-r--r-- | Library/Homebrew/dependency.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/Library/Homebrew/dependency.rb b/Library/Homebrew/dependency.rb index f10ebd27f..d3e8b607a 100644 --- a/Library/Homebrew/dependency.rb +++ b/Library/Homebrew/dependency.rb @@ -46,7 +46,6 @@ class Dependency def missing_options(inherited_options=[]) missing = options | inherited_options missing -= Tab.for_formula(to_formula).used_options - missing -= to_formula.build.implicit_options missing end |