diff options
| author | Jack Nagel | 2013-07-16 23:15:22 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-07-16 23:15:22 -0500 |
| commit | d9790309a61cbd01168de1a3b0de8900ea85fbb2 (patch) | |
| tree | 6f561293c9ec5e838d7d9c72db1189791cbd8a3d /Library/Homebrew/cmd | |
| parent | f432a59fd0d68a7b17143699fa7e4dc93bd6a5e8 (diff) | |
| download | brew-d9790309a61cbd01168de1a3b0de8900ea85fbb2.tar.bz2 | |
Fix SYMROOT audit
Diffstat (limited to 'Library/Homebrew/cmd')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 5153e7b23..785b63b29 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -331,7 +331,14 @@ class FormulaAuditor end end - def audit_text(line) + def audit_text + # xcodebuild should specify SYMROOT + if text=~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/ + problem "xcodebuild should be passed an explicit \"SYMROOT\"" + end + end + + def audit_line(line) if line =~ /<(Formula|AmazonWebServicesFormula|ScriptFileFormula|GithubGistFormula)/ problem "Use a space in class inheritance: class Foo < #{$1}" end @@ -423,11 +430,6 @@ class FormulaAuditor problem "Use spaces instead of tabs for indentation" end - # xcodebuild should specify SYMROOT - if line =~ /system\s+['"]xcodebuild/ and not line =~ /SYMROOT=/ - problem "xcodebuild should be passed an explicit \"SYMROOT\"" - end - if line =~ /ENV\.x11/ problem "Use \"depends_on :x11\" instead of \"ENV.x11\"" end @@ -609,7 +611,8 @@ class FormulaAuditor audit_deps audit_conflicts audit_patches - text.each_line { |line| audit_text(line) } + audit_text + text.each_line { |line| audit_line(line) } audit_python audit_installed end |
