bottle: don't read mtime from nonexistant files

If the source contains a broken symlink, `brew bottle` would fail for no
good reason when trying to determine the most recently modified
file. To avoid this, we ignore any files for which stat(2) fails.

Closes Homebrew/homebrew#47111.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

1 files changed, 5 insertions, 1 deletions

diff --git a/Library/Homebrew/cmd/bottle.rb b/Library/Homebrew/cmd/bottle.rb
index fe2829c19..4c629cdbb 100644
--- a/Library/Homebrew/cmd/bottle.rb
+++ b/Library/Homebrew/cmd/bottle.rb
@@ -140,6 +140,10 @@ module Homebrew
     erb.result(bottle.instance_eval { binding }).gsub(/^\s*$\n/, "")
   end
 
+  def most_recent_mtime(pathname)
+    pathname.to_enum(:find).select(&:exist?).map(&:mtime).max
+  end
+
   def bottle_formula(f)
     unless f.installed?
       return ofail "Formula not installed or up-to-date: #{f.full_name}"
@@ -187,7 +191,7 @@ module Homebrew
     skip_relocation = false
 
     formula_source_time = f.stable.stage do
-      Pathname.pwd.to_enum(:find).map(&:mtime).max
+      most_recent_mtime(Pathname.pwd)
     end
 
     keg.lock do