diff options
| author | Jack Nagel | 2013-06-27 21:11:16 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-06-27 21:17:28 -0500 |
| commit | 0f2c5f33a2f44e484f9e9a44729e39d5b9fc94ee (patch) | |
| tree | 27a815736e26839a759bec7a9e63d0c4eb9d230a /Library/Homebrew/cmd | |
| parent | db38053840d6d8e4b615503bc1e362048eb40c77 (diff) | |
| download | brew-0f2c5f33a2f44e484f9e9a44729e39d5b9fc94ee.tar.bz2 | |
Add an exception for imagemagick in build-time dep audit
Diffstat (limited to 'Library/Homebrew/cmd')
| -rw-r--r-- | Library/Homebrew/cmd/audit.rb | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 79df38599..f19a461a7 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -145,10 +145,14 @@ class FormulaAuditor case dep.name when *BUILD_TIME_DEPS - # Build deps should be tagged - problem <<-EOS.undent unless dep.tags.any? || f.name =~ /automake/ && dep.name == 'autoconf' - #{dep} dependency should be "depends_on '#{dep}' => :build" - EOS + # TODO: this should really be only dep.build? but maybe some formula + # depends on the current behavior to be audit-clean? + next if dep.tags.any? + next if f.name =~ /automake/ && dep.name == 'autoconf' + # This is actually a libltdl dep that gets converted to a non-build time + # libtool dep, but I don't of a good way to encode this in the dep object + next if f.name == 'imagemagick' && dep.name == 'libtool' + problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"} when "git", "ruby", "emacs", "mercurial" problem <<-EOS.undent Don't use #{dep} as a dependency. We allow non-Homebrew |
