various: eliminate the usage of `any?` (#638)

`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).

1 files changed, 6 insertions, 2 deletions

diff --git a/Library/Homebrew/cmd/outdated.rb b/Library/Homebrew/cmd/outdated.rb
index dfd61226a..a318b65f6 100644
--- a/Library/Homebrew/cmd/outdated.rb
+++ b/Library/Homebrew/cmd/outdated.rb
@@ -17,13 +17,17 @@ require "keg"
 
 module Homebrew
   def outdated
-    formulae = ARGV.resolved_formulae.any? ? ARGV.resolved_formulae : Formula.installed
+    formulae = if ARGV.resolved_formulae.empty?
+      Formula.installed
+    else
+      ARGV.resolved_formulae
+    end
     if ARGV.json == "v1"
       outdated = print_outdated_json(formulae)
     else
       outdated = print_outdated(formulae)
     end
-    Homebrew.failed = ARGV.resolved_formulae.any? && outdated.any?
+    Homebrew.failed = !ARGV.resolved_formulae.empty? && !outdated.empty?
   end
 
   def print_outdated(formulae)