Merge pull request #3514 from reitermarkus/system_command

Fix SystemCommand escaping … again.

1 files changed, 8 insertions, 6 deletions

diff --git a/Library/Homebrew/cask/lib/hbc/system_command.rb b/Library/Homebrew/cask/lib/hbc/system_command.rb
index f64d85c07..a890c42e4 100644
--- a/Library/Homebrew/cask/lib/hbc/system_command.rb
+++ b/Library/Homebrew/cask/lib/hbc/system_command.rb
@@ -50,11 +50,7 @@ module Hbc
     end
 
     def command
-      @command ||= if sudo?
-        [*sudo_prefix, executable, *args]
-      else
-        [Shellwords.shellescape(executable), *args]
-      end
+      [*sudo_prefix, executable, *args]
     end
 
     private
@@ -85,8 +81,14 @@ module Hbc
     end
 
     def each_output_line(&b)
+      executable, *args = expanded_command
+
+      unless File.exist?(executable)
+        executable = which(executable, PATH.new(ENV["PATH"], HOMEBREW_PREFIX/"bin"))
+      end
+
       raw_stdin, raw_stdout, raw_stderr, raw_wait_thr =
-        Open3.popen3(*expanded_command, **options)
+        Open3.popen3([executable, executable], *args, **options)
 
       write_input_to(raw_stdin)
       raw_stdin.close_write