aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Schimandl2017-10-08 09:59:29 +0200
committerMartin Schimandl2017-11-10 20:16:38 +0100
commitdfe4e7641a71aef693831134c8db406e3252fa88 (patch)
tree542282e5608957c8f6ea5fec972c6ca1ddec6182
parent99b76360081ac92f75792ecea049b3dba496c659 (diff)
downloadbrew-dfe4e7641a71aef693831134c8db406e3252fa88.tar.bz2
combine errors to a single if-statement. fix spec test
-rw-r--r--Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb18
-rw-r--r--Library/Homebrew/test/cask/cli/internal_stanza_spec.rb5
2 files changed, 12 insertions, 11 deletions
diff --git a/Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb b/Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb
index 05d939a4b..4f8569444 100644
--- a/Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb
+++ b/Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb
@@ -71,16 +71,16 @@ module Hbc
next
end
- if value.nil? || (value.is_a?(Array) && value.empty?)
- opoo "no such stanza '#{stanza}' on Cask '#{cask}'" unless quiet?
- puts ""
- raise ArgumentError, "no such stanza '#{stanza}' on Cask '#{cask}'"
- end
+ if (value.nil? || value.is_a?(Array) && value.empty?) ||
+ (artifact_name && !value.key?(artifact_name))
- if artifact_name && !value.key?(artifact_name)
- opoo "no such stanza '#{artifact_name}' on Cask '#{cask}'" unless quiet?
- puts ""
- raise ArgumentError, "no such stanza '#{artifact_name}' on Cask '#{cask}'"
+ if artifact_name
+ thing = artifact_name
+ else
+ thing = stanza
+ end
+
+ raise CaskError, "no such stanza '#{thing}' on Cask '#{cask}'"
end
if stanza == :artifacts
diff --git a/Library/Homebrew/test/cask/cli/internal_stanza_spec.rb b/Library/Homebrew/test/cask/cli/internal_stanza_spec.rb
index 1599ca843..38fa1b840 100644
--- a/Library/Homebrew/test/cask/cli/internal_stanza_spec.rb
+++ b/Library/Homebrew/test/cask/cli/internal_stanza_spec.rb
@@ -1,8 +1,9 @@
describe Hbc::CLI::InternalStanza, :cask do
it "shows stanza of the Specified Cask" do
command = described_class.new("gpg", "with-gpg")
- command.run
- # TODO: check result
+ expect do
+ command.run
+ end.to output("http://example.com/gpg-signature.asc\n").to_stdout
end
it "raises an exception when stanza is invalid" do