diff options
| author | Mike McQuaid | 2016-09-17 20:45:39 +0100 |
|---|---|---|
| committer | GitHub | 2016-09-17 20:45:39 +0100 |
| commit | c419f928ba5d152fc41a8abc8f33f88bfe3e1971 (patch) | |
| tree | 365ad3248e0d3b9539b0d147a5d0bf968d32a327 | |
| parent | 295e937f270826aef4e64f0056950a948e3502b1 (diff) | |
| parent | f989346c0348d9bab091fbb12dc73e3b372aaab2 (diff) | |
| download | brew-c419f928ba5d152fc41a8abc8f33f88bfe3e1971.tar.bz2 | |
Merge pull request #980 from JCount/how-to-open-PR--update
How-To-PR: both stable & devel in simple commit message
| -rw-r--r-- | share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md b/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md index 1afa01ddb..03d3a00fa 100644 --- a/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md +++ b/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md @@ -41,7 +41,7 @@ To make a new branch and submit it for review, create a GitHub pull request with 6. Make a separate commit for each changed formula with `git add` and `git commit`. 7. Upload your new commits to the branch on your fork with `git push --set-upstream <YOUR_USERNAME> <YOUR_BRANCH_NAME>`. 8. Go to https://github.com/Homebrew/homebrew-core and create a pull request to request review and merging of the commits in your pushed branch. Explain why the change is needed and, if fixing a bug, how to reproduce the bug. Make sure you have done each step in the checklist that appears in your new PR. - * Please note that our preferred commit message format for simple version updates is "`<FORMULA_NAME> <NEW_VERSION>`", e.g. "`source-highlight 3.1.8`". `devel` version updates should have the commit message suffixed with `(devel)`, e.g. "`nginx 1.9.1 (devel)`". If updating both stable and `devel`, just list the stable (main) version. + * Please note that our preferred commit message format for simple version updates is "`<FORMULA_NAME> <NEW_VERSION>`", e.g. "`source-highlight 3.1.8`". `devel` version updates should have the commit message suffixed with `(devel)`, e.g. "`nginx 1.9.1 (devel)`". If updating both stable and `devel`, the format should be a concatenation of these two forms, e.g. "`x264 r2699, r2705 (devel)`". 9. Await feedback or a merge from Homebrew's maintainers. We typically respond to all PRs within a couple days, but it may take up to a week, depending on the maintainers' workload. 10. Thank you! |