aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlyssa Ross2017-09-07 12:09:52 +0100
committerAlyssa Ross2017-09-07 12:12:22 +0100
commitb6d36003b336dee36d4c11a621b4061bc0615284 (patch)
treefc85314e6f45d5323bd5e8fbead3ca718f83b42b
parent5b041528aff269a003e9be786d52466002a23b2a (diff)
downloadbrew-b6d36003b336dee36d4c11a621b4061bc0615284.tar.bz2
Always output when tapping core
Hiding all output makes it look like Homebrew is hanging while the tap operation (which can take a long time!) is running. Closes #3053.
-rw-r--r--Library/Homebrew/cmd/update-report.rb2
-rw-r--r--Library/Homebrew/tap.rb6
2 files changed, 3 insertions, 5 deletions
diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb
index 164413cd1..781ee8808 100644
--- a/Library/Homebrew/cmd/update-report.rb
+++ b/Library/Homebrew/cmd/update-report.rb
@@ -124,7 +124,7 @@ module Homebrew
return if ENV["HOMEBREW_UPDATE_TEST"]
core_tap = CoreTap.instance
return if core_tap.installed?
- CoreTap.ensure_installed! quiet: false
+ CoreTap.ensure_installed!
revision = core_tap.git_head
ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision
ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision
diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb
index f232be428..f6246aad9 100644
--- a/Library/Homebrew/tap.rb
+++ b/Library/Homebrew/tap.rb
@@ -551,11 +551,9 @@ class CoreTap < Tap
@instance ||= new
end
- def self.ensure_installed!(options = {})
+ def self.ensure_installed!
return if instance.installed?
- args = ["tap", instance.name]
- args << "-q" if options.fetch(:quiet, true)
- safe_system HOMEBREW_BREW_FILE, *args
+ safe_system HOMEBREW_BREW_FILE, "tap", instance.name
end
# @private