diff options
| author | Martin Afanasjew | 2016-07-04 07:19:44 +0200 |
|---|---|---|
| committer | GitHub | 2016-07-04 07:19:44 +0200 |
| commit | a49f3a8e91df8ccbbd7335deab1853ce395c5be4 (patch) | |
| tree | 27d7104c7753c172ec92451c503216a81efcdf11 | |
| parent | f4b3dadb64ad0101e60196db4d7c202b3f6b1f0b (diff) | |
| download | brew-a49f3a8e91df8ccbbd7335deab1853ce395c5be4.tar.bz2 | |
style: use RuboCop 0.41.1 (#433)
Tweak `Style/NumericLiteralPrefix` cop settings as we're using octal
literals a lot (both in formulae and the package manager) for file
permissions and aren't ready just yet to transition them to the more
beginner-friendly `0o` prefix (instead of the more obscure `0` prefix).
| -rw-r--r-- | Library/.rubocop.yml | 4 | ||||
| -rw-r--r-- | Library/Homebrew/cmd/style.rb | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index c532bede0..74a488917 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -66,6 +66,10 @@ Style/EmptyLineBetweenDefs: Style/NumericLiterals: Enabled: false +# zero-prefixed octal literals are just too widely used (and mostly understood) +Style/NumericLiteralPrefix: + EnforcedOctalStyle: zero_only + # consistency and readability when faced with string interpolation Style/PercentLiteralDelimiters: PreferredDelimiters: diff --git a/Library/Homebrew/cmd/style.rb b/Library/Homebrew/cmd/style.rb index 2356a031b..0e756ad0c 100644 --- a/Library/Homebrew/cmd/style.rb +++ b/Library/Homebrew/cmd/style.rb @@ -47,7 +47,7 @@ module Homebrew def check_style_impl(files, output_type, options = {}) fix = options[:fix] - Homebrew.install_gem_setup_path! "rubocop", "0.40" + Homebrew.install_gem_setup_path! "rubocop", "0.41.1" args = %W[ --force-exclusion |