aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWilliam Woodruff2017-01-11 23:07:26 -0500
committerWilliam Woodruff2017-01-11 23:07:26 -0500
commit82c046b3e1aab914dc7d785720029ac50d49992e (patch)
treec04554b245af2a22ec11ffe2a04a551216d45c30
parentf7bccee2145547d21b2629cab8b5fddff3299bda (diff)
downloadbrew-82c046b3e1aab914dc7d785720029ac50d49992e.tar.bz2
audit: Check for invocations of cctools.
Now that ruby-macho is available, cctools should be invoked as little as possible.
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 6d43c51bf..4314bb3c2 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -1039,6 +1039,10 @@ class FormulaAuditor
problem "'fails_with :llvm' is now a no-op so should be removed"
end
+ if line =~ /system\s+['"](otool)|(install_name_tool)|(lipo)/
+ problem "Use ruby-macho instead of calling #{$1}"
+ end
+
if formula.tap.to_s == "homebrew/core"
["OS.mac?", "OS.linux?"].each do |check|
next unless line.include?(check)