aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2017-06-02 22:25:07 +0100
committerMike McQuaid2017-06-02 22:25:07 +0100
commit82b113cdd09031ef45111745946d2f12aca97555 (patch)
tree1873a2189338a50aa7ab6a7fc071e3bda87ee61b
parent0731a68cde75206682ed972beb47930afa3c434e (diff)
downloadbrew-82b113cdd09031ef45111745946d2f12aca97555.tar.bz2
formula_desc_cop: desc should be capitalised.
Note that the formula description field should start with a capital letter.
-rw-r--r--Library/Homebrew/rubocops/formula_desc_cop.rb7
1 files changed, 6 insertions, 1 deletions
diff --git a/Library/Homebrew/rubocops/formula_desc_cop.rb b/Library/Homebrew/rubocops/formula_desc_cop.rb
index 81068ac34..54a14b39d 100644
--- a/Library/Homebrew/rubocops/formula_desc_cop.rb
+++ b/Library/Homebrew/rubocops/formula_desc_cop.rb
@@ -32,13 +32,18 @@ module RuboCop
# Check if command-line is wrongly used in formula's desc
if match = regex_match_group(desc, /(command ?line)/i)
- problem "Description should use \"command-line\" instead of \"#{match}\""
+ c = match.to_s.chars.first
+ problem "Description should use \"#{c}ommand-line\" instead of \"#{match}\""
end
if match = regex_match_group(desc, /^(an?)\s/i)
problem "Description shouldn't start with an indefinite article (#{match})"
end
+ if regex_match_group(desc, /^[a-z]/)
+ problem "Description should start with a capital letter"
+ end
+
# Check if formula's name is used in formula's desc
problem "Description shouldn't include the formula name" if regex_match_group(desc, /^#{@formula_name}\b/i)
end