aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2017-08-07 10:12:52 +0100
committerMike McQuaid2017-08-07 10:12:52 +0100
commit82173856272b354c067e826d1d4fb77d8dae1ded (patch)
tree408f16b7329b10bf8bdef08611f4294db268a487
parentc26c9204fa48c8d2bfa3837193eaf2a82b611fa6 (diff)
downloadbrew-82173856272b354c067e826d1d4fb77d8dae1ded.tar.bz2
software_spec: improve no resource version error.
This should make it clearer to us that they needed to `brew update`. Fixes https://github.com/Homebrew/homebrew-core/issues/16075 Fixes https://github.com/Homebrew/brew/issues/2944
-rw-r--r--Library/Homebrew/software_spec.rb14
1 files changed, 12 insertions, 2 deletions
diff --git a/Library/Homebrew/software_spec.rb b/Library/Homebrew/software_spec.rb
index c6e704350..49d818f0f 100644
--- a/Library/Homebrew/software_spec.rb
+++ b/Library/Homebrew/software_spec.rb
@@ -51,8 +51,18 @@ class SoftwareSpec
@owner = owner
@resource.owner = self
resources.each_value do |r|
- r.owner = self
- r.version ||= (version.head? ? Version.create("HEAD") : version.dup)
+ r.owner = self
+ r.version ||= begin
+ if version.nil?
+ raise "#{full_name}: version missing for \"#{r.name}\" resource!"
+ end
+
+ if version.head?
+ Version.create("HEAD")
+ else
+ version.dup
+ end
+ end
end
patches.each { |p| p.owner = self }
end