aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Afanasjew2015-11-09 23:08:50 +0100
committerXu Cheng2015-11-11 14:22:44 +0800
commit8091b33f85c96a93d14de80ce3bfd9c32f8bb58c (patch)
treec493db948a4457ecf4369d9f1ae8be5e4c034bf7
parent4296ec63ebe547466338a1df327a2069533bb5ec (diff)
downloadbrew-8091b33f85c96a93d14de80ce3bfd9c32f8bb58c.tar.bz2
ruby 1.8: address syntax warnings in Homebrew core
Closes Homebrew/homebrew#45849. Signed-off-by: Xu Cheng <xucheng@me.com>
-rw-r--r--Library/Homebrew/cmd/audit.rb2
-rw-r--r--Library/Homebrew/test/test_formula.rb2
-rw-r--r--Library/Homebrew/test/test_migrator.rb2
-rw-r--r--Library/Homebrew/test/test_pathname.rb2
4 files changed, 4 insertions, 4 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 1d293994f..231e583bb 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -600,7 +600,7 @@ class FormulaAuditor
problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\""
end
- if text =~ /system "npm", "install"/ && text !~ %r[opt_libexec}/npm/bin]
+ if text =~ /system "npm", "install"/ && text !~ %r[opt_libexec\}/npm/bin]
need_npm = "\#{Formula[\"node\"].opt_libexec\}/npm/bin"
problem <<-EOS.undent
Please add ENV.prepend_path \"PATH\", \"#{need_npm}"\ to def install
diff --git a/Library/Homebrew/test/test_formula.rb b/Library/Homebrew/test/test_formula.rb
index 4d198ba28..c30f595bf 100644
--- a/Library/Homebrew/test/test_formula.rb
+++ b/Library/Homebrew/test/test_formula.rb
@@ -33,7 +33,7 @@ class FormulaTests < Homebrew::TestCase
refute_predicate f, :any_version_installed?
prefix = HOMEBREW_CELLAR+f.name+"0.1"
prefix.mkpath
- FileUtils.touch (prefix+Tab::FILENAME)
+ FileUtils.touch prefix+Tab::FILENAME
assert_predicate f, :any_version_installed?
ensure
f.rack.rmtree
diff --git a/Library/Homebrew/test/test_migrator.rb b/Library/Homebrew/test/test_migrator.rb
index f69da3f6f..781635093 100644
--- a/Library/Homebrew/test/test_migrator.rb
+++ b/Library/Homebrew/test/test_migrator.rb
@@ -184,7 +184,7 @@ class MigratorTests < Homebrew::TestCase
assert_predicate @new_keg_record, :exist?
assert_predicate @old_keg_record.parent, :symlink?
- refute_predicate (HOMEBREW_LIBRARY/"LinkedKegs/oldname"), :exist?
+ refute_predicate HOMEBREW_LIBRARY/"LinkedKegs/oldname", :exist?
assert_equal @new_keg_record.realpath, (HOMEBREW_LIBRARY/"LinkedKegs/newname").realpath
assert_equal @new_keg_record.realpath, @old_keg_record.realpath
assert_equal @new_keg_record.realpath, (HOMEBREW_PREFIX/"opt/oldname").realpath
diff --git a/Library/Homebrew/test/test_pathname.rb b/Library/Homebrew/test/test_pathname.rb
index 0f36038dc..5456c5bdc 100644
--- a/Library/Homebrew/test/test_pathname.rb
+++ b/Library/Homebrew/test/test_pathname.rb
@@ -216,7 +216,7 @@ class PathnameInstallTests < Homebrew::TestCase
assert_predicate @dst+"bin", :directory?
assert_predicate @dst+"bin/a.txt", :exist?
assert_predicate @dst+"bin/b.txt", :exist?
- assert_predicate (@dst+"bin").readlink, :relative?
+ assert_predicate((@dst+"bin").readlink, :relative?)
end
def test_install_relative_symlink