diff options
| author | Ben Muschol | 2017-08-14 11:41:29 -0400 |
|---|---|---|
| committer | Ben Muschol | 2017-08-14 12:06:12 -0400 |
| commit | 68cdb550f7b90318a136e4dd484249ab678f5fbc (patch) | |
| tree | 4f055be5d5e432aac6f32408403663b5bd938982 | |
| parent | 603bdd01a81e62d6b97a5da26d75d409e839a8fa (diff) | |
| download | brew-68cdb550f7b90318a136e4dd484249ab678f5fbc.tar.bz2 | |
Spec for issues search
| -rw-r--r-- | Library/Homebrew/test/utils/github_spec.rb | 8 | ||||
| -rw-r--r-- | Library/Homebrew/utils/github.rb | 2 |
2 files changed, 9 insertions, 1 deletions
diff --git a/Library/Homebrew/test/utils/github_spec.rb b/Library/Homebrew/test/utils/github_spec.rb index 5c315aec4..80f0ef786 100644 --- a/Library/Homebrew/test/utils/github_spec.rb +++ b/Library/Homebrew/test/utils/github_spec.rb @@ -28,4 +28,12 @@ describe GitHub do expect(query).to eq("q=user%3AHomebrew+user%3Acaskroom&per_page=100") end end + + describe "::issues_matching", :needs_network do + it "queries GitHub issues with the passed parameters" do + results = subject.issues_matching("brew search", repo: "Homebrew/brew", author: "avetamine", is: "closed") + expect(results.count).to eq(1) + expect(results.first["title"]).to eq("brew search : 422 Unprocessable Entity") + end + end end diff --git a/Library/Homebrew/utils/github.rb b/Library/Homebrew/utils/github.rb index 960b563d9..8096c7b9c 100644 --- a/Library/Homebrew/utils/github.rb +++ b/Library/Homebrew/utils/github.rb @@ -266,7 +266,7 @@ module GitHub puts "Closed pull requests:" prs = open_or_closed_prs else - return + return [] end prs.each { |i| puts "#{i["title"]} (#{i["html_url"]})" } |
