aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJCount2017-03-05 14:19:32 -0500
committerJCount2017-03-05 14:19:32 -0500
commit4e50562424e246743b117167c732dc3988f561d2 (patch)
treef3f5cf2c39104ad5781f87ffa73c3891ecf8ff27
parent43bfaa19f1007776e1809a130568e765adc9a7e8 (diff)
downloadbrew-4e50562424e246743b117167c732dc3988f561d2.tar.bz2
audit: whitelist bash-completion@* to use conflicts_with
this is necessary because they install conflicting scripts into HOMEBREW_PREFIX/etc/profile.d
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb5
1 files changed, 4 insertions, 1 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index d18e3b821..30f39485a 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -532,8 +532,11 @@ class FormulaAuditor
end
end
+ versioned_conflicts_whitelist = %w[node@ bash-completion@]
+
return unless formula.conflicts.any? && formula.versioned_formula?
- return if formula.name.start_with? "node@"
+ versioned_conflicts_whitelist.each { |c|
+ return if formula.name.start_with? c }
problem <<-EOS
Versioned formulae should not use `conflicts_with`.
Use `keg_only :versioned_formula` instead.