aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2014-10-17 22:41:26 -0500
committerJack Nagel2014-10-17 22:41:26 -0500
commit41cc28ca42e1bcaa9716d6c7930ec9c492ffa356 (patch)
tree7104807783fe8eb4110577f769e0e3da1573ab64
parentca2680d77f312ec8bd8c06467adb1d5077fbed81 (diff)
downloadbrew-41cc28ca42e1bcaa9716d6c7930ec9c492ffa356.tar.bz2
Pull conditional out of begin block
-rw-r--r--Library/Homebrew/formula_installer.rb15
1 files changed, 8 insertions, 7 deletions
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index f180a1663..c9033ce29 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -154,16 +154,17 @@ class FormulaInstaller
@@attempted << f
- begin
- if pour_bottle? :warn => true
+ if pour_bottle?(:warn => true)
+ begin
pour
+ rescue => e
+ raise if ARGV.homebrew_developer?
+ @pour_failed = true
+ onoe e.message
+ opoo "Bottle installation failed: building from source."
+ else
@poured_bottle = true
end
- rescue => e
- raise e if ARGV.homebrew_developer?
- @pour_failed = true
- onoe e.message
- opoo "Bottle installation failed: building from source."
end
build_bottle_preinstall if build_bottle?