aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXu Cheng2015-02-19 18:27:50 +0800
committerXu Cheng2015-02-19 18:49:15 +0800
commit40e64263226d4017b2437fbd5fd777c41ab3f063 (patch)
treed1979e7ecc311850cb32dc7c9da94183b80f4abf
parent6dd51ff399df505921336faba3170611991b1d96 (diff)
downloadbrew-40e64263226d4017b2437fbd5fd777c41ab3f063.tar.bz2
audit: give better suggestion on git/hg dependency
Closes Homebrew/homebrew#36959. Signed-off-by: Xu Cheng <xucheng@me.com>
-rw-r--r--Library/Homebrew/cmd/audit.rb8
1 files changed, 6 insertions, 2 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 3d5f6c440..2ab655df4 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -174,8 +174,12 @@ class FormulaAuditor
Or if it is indeed a runtime denpendency
depends_on "#{dep}" => :run
EOS
- when "git", "ruby", "mercurial"
- problem "Don't use #{dep} as a dependency. We allow non-Homebrew #{dep} installations."
+ when "git"
+ problem "Use `depends_on :git` instead of `depends_on 'git'`"
+ when "mercurial"
+ problem "Use `depends_on :hg` instead of `depends_on 'mercurial'`"
+ when "ruby"
+ problem "Don't use ruby as a dependency. We allow non-Homebrew ruby installations."
when 'gfortran'
problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`"
when 'open-mpi', 'mpich2'