aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2016-12-29 12:32:39 +0000
committerGitHub2016-12-29 12:32:39 +0000
commit27695ffeeb829ca129a87fe53f60502978ab367b (patch)
tree74ed174a371898ef0d4ff4bcc66edaa99cdf3f2f
parent85f62afae69395457faed7a17c49a8c74484a861 (diff)
parent8ffe231f44f18aeb482a213e50c3959a3f6405ab (diff)
downloadbrew-27695ffeeb829ca129a87fe53f60502978ab367b.tar.bz2
Merge pull request #1700 from MikeMcQuaid/no-libressl-and-openssl
audit: don't allow openssl & libressl dependency.
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index 93431c951..ef22cbb7a 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -788,6 +788,10 @@ class FormulaAuditor
problem "Please set plist_options when using a formula-defined plist."
end
+ if text =~ /depends_on\s+['"]openssl['"]/ && text =~ /depends_on\s+['"]libressl['"]/
+ problem "Formulae should not depend on both OpenSSL and LibreSSL (even optionally)."
+ end
+
return unless text.include?('require "language/go"') && !text.include?("go_resource")
problem "require \"language/go\" is unnecessary unless using `go_resource`s"
end