diff options
| author | JCount | 2017-10-21 22:28:16 -0400 |
|---|---|---|
| committer | JCount | 2017-10-26 09:57:03 -0400 |
| commit | 224864b1490700e995a0133d6fdd4edefb645c0a (patch) | |
| tree | a6e77b23e9b4ef4beb98af11b39d21e182769783 | |
| parent | feb3e35e3c174f4c53ff04f929429995b72f3bf9 (diff) | |
| download | brew-224864b1490700e995a0133d6fdd4edefb645c0a.tar.bz2 | |
java_requirement: support prompting users to install legacy Java casks
This enhances the Java requirement to support prompting the user
to install the correct legacy Java version via Cask for formulae
that don't yet work with the latest version of Java. Previously,
even if the formula had a strict requirement that a specific,
older version of Java be used, the messaging would tell the user to
`brew cask install java` (i.e. to install the latest version of Java),
which wouldn't actually satisfy the requirement.
| -rw-r--r-- | Library/Homebrew/extend/os/mac/requirements/java_requirement.rb | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/Library/Homebrew/extend/os/mac/requirements/java_requirement.rb b/Library/Homebrew/extend/os/mac/requirements/java_requirement.rb index 2f132d740..2a48f02bd 100644 --- a/Library/Homebrew/extend/os/mac/requirements/java_requirement.rb +++ b/Library/Homebrew/extend/os/mac/requirements/java_requirement.rb @@ -1,13 +1,30 @@ class JavaRequirement < Requirement - cask "java" - env do env_java_common env_oracle_jdk || env_apple end + # A strict Java 8 requirement (1.8) should prompt the user to install + # the legacy java8 cask because the current version, Java 9, is not + # completely backwards compatible, and contains breaking changes such as + # strong encapsulation of JDK-internal APIs and a modified version scheme + # (9.0 not 1.9). + def cask + if @version.nil? || @version.to_s.end_with?("+") || + @version.to_f >= JAVA_CASK_MAP.keys.max.to_f + JAVA_CASK_MAP.fetch(JAVA_CASK_MAP.keys.max) + else + JAVA_CASK_MAP.fetch("1.8") + end + end + private + JAVA_CASK_MAP = { + "1.8" => "caskroom/versions/java8", + "9.0" => "java", + }.freeze + def possible_javas javas = [] javas << Pathname.new(ENV["JAVA_HOME"])/"bin/java" if ENV["JAVA_HOME"] |