aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDominyk Tiller2016-07-31 02:00:33 +0100
committerDominyk Tiller2016-07-31 03:44:29 +0100
commit202f793d8a46bcc186740429af26ea14093d49f8 (patch)
tree866ffe73ecf0b16096e88df88a58b2ae6f484a05
parent1244aa6ecec36541a96ea4a2ee9840bde30fed4a (diff)
downloadbrew-202f793d8a46bcc186740429af26ea14093d49f8.tar.bz2
cleaner: kill unnecessary perl elements
We shouldn't be packaging either `perllocal.pod` or `.packlist` files. Both are only really useful outside of package management. They get automatically generated whenever you install a Perl module. Debian, Arch, MacPorts & others remove them and we should have been as well really; keeping them causes completely unnecessary conflicts between formulae.
-rw-r--r--Library/Homebrew/cleaner.rb10
1 files changed, 10 insertions, 0 deletions
diff --git a/Library/Homebrew/cleaner.rb b/Library/Homebrew/cleaner.rb
index e20d1b7e6..d8a998576 100644
--- a/Library/Homebrew/cleaner.rb
+++ b/Library/Homebrew/cleaner.rb
@@ -1,6 +1,8 @@
# Cleans a newly installed keg.
# By default:
# * removes .la files
+# * removes perllocal.pod files
+# * removes .packlist files
# * removes empty directories
# * sets permissions on executables
# * removes unresolved symlinks
@@ -89,6 +91,14 @@ class Cleaner
next
elsif path.extname == ".la"
path.unlink
+ elsif path.basename.to_s == "perllocal.pod"
+ # Both this file & the .packlist one below are completely unnecessary
+ # to package & causes pointless conflict with other formulae. They are
+ # removed by Debian, Arch & MacPorts amongst other packagers as well.
+ # The files are created as part of installing any Perl module.
+ path.unlink
+ elsif path.basename.to_s == ".packlist" # Hidden file, not file extension!
+ path.unlink
else
# Set permissions for executables and non-executables
perms = if executable_path?(path)