aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2014-08-11 20:15:25 +0100
committerMike McQuaid2014-08-11 20:18:15 +0100
commit1455d83dd8bb7b2a7fbd946eb4dd757c060b06a6 (patch)
treeef08505d611214f38119b7b2b3f6f1e173c53622
parent4790d4cba9fccc3f7e2683ed905968890e3c63d1 (diff)
downloadbrew-1455d83dd8bb7b2a7fbd946eb4dd757c060b06a6.tar.bz2
formula_installer: check for recommended/optional.
build.without? seemingly always returns true for requirements that are neither recommended nor optional so check these before deciding not to install a default formula. Closes Homebrew/homebrew#31511.
-rw-r--r--Library/Homebrew/formula_installer.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index 2b064107b..63b7fa0df 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -241,7 +241,7 @@ class FormulaInstaller
def install_requirement_default_formula?(req, build)
return false unless req.default_formula?
- return false if build.without?(req)
+ return false if build.without?(req) && (req.recommended? || req.optional?)
return true unless req.satisfied?
pour_bottle? || build_bottle?
end