aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2013-06-14 18:37:26 -0500
committerJack Nagel2013-06-14 18:37:27 -0500
commit113125d394d2b9530aec111574da10e46b554f5a (patch)
tree7b4346a90077f029c62ced1cf9a0d3679187b382
parentca10e5005abcf36fba5760b60c0aeeefa5ca6505 (diff)
downloadbrew-113125d394d2b9530aec111574da10e46b554f5a.tar.bz2
Remove Version#to_a alias
Exposing this as "to_a" was a mistake, versions are not arrays and it causes incorrect behavior when splatted or using Kernel#Array(). Use the more correct name "tokens" instead.
-rw-r--r--Library/Homebrew/requirements/python_dependency.rb4
-rw-r--r--Library/Homebrew/version.rb1
2 files changed, 2 insertions, 3 deletions
diff --git a/Library/Homebrew/requirements/python_dependency.rb b/Library/Homebrew/requirements/python_dependency.rb
index bd3cf1e85..c3753d813 100644
--- a/Library/Homebrew/requirements/python_dependency.rb
+++ b/Library/Homebrew/requirements/python_dependency.rb
@@ -24,10 +24,10 @@ class PythonInstalled < Requirement
class PythonVersion < Version
def major
- to_a[0].to_s.to_i # Python's major.minor are always ints.
+ tokens[0].to_s.to_i # Python's major.minor are always ints.
end
def minor
- to_a[1].to_s.to_i
+ tokens[1].to_s.to_i
end
end
diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb
index d969f298c..07d042eb1 100644
--- a/Library/Homebrew/version.rb
+++ b/Library/Homebrew/version.rb
@@ -184,7 +184,6 @@ class Version
def tokens
@tokens ||= tokenize
end
- alias_method :to_a, :tokens
def tokenize
@version.scan(