aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2014-03-06 21:15:17 +0000
committerMike McQuaid2014-03-08 00:54:35 +0000
commit1070acfe7ac95de63e736c3005efcdf1ce37b472 (patch)
tree15acc10c941a434ad8ab46ff465308b9326a648a
parent1fd8e7fd75dbaffab57d6fdf84170a367f41c425 (diff)
downloadbrew-1070acfe7ac95de63e736c3005efcdf1ce37b472.tar.bz2
audit: don't use GitHub zip files.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
-rw-r--r--Library/Homebrew/cmd/audit.rb5
1 files changed, 5 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 99c957b4b..1a81a55d1 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -265,6 +265,11 @@ class FormulaAuditor
urls.select { |u| u =~ %r[https://.*/(?:tar|zip)ball/] && u !~ %r[\.git$] }.each do |u|
problem "Use /archive/ URLs for GitHub tarballs (url is #{u})."
end
+
+ # Don't use GitHub .zip files
+ urls.select { |u| u =~ %r[https://.*github.*/(archive|releases)/.*\.zip$] && u !~ %r[releases/download] }.each do |u|
+ problem "Use GitHub tarballs rather than zipballs (url is #{u})."
+ end
end
def audit_specs