aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2017-04-10 22:42:57 +0100
committerMike McQuaid2017-04-10 22:42:57 +0100
commit0948d2013adba23ecf22b59a2ff61453c2b6f63e (patch)
treea2ff8a448ed9ec5b144b364ea93ea2da2189679f
parent4d6e31999aa69d8498c87ceacc7fddaa5e3c409b (diff)
downloadbrew-0948d2013adba23ecf22b59a2ff61453c2b6f63e.tar.bz2
audit: deprecate language module requirements.
Make `brew audit` complain about language module requirements because they provide a crappy user experience compared to vendoring and we’re not really fixing bugs in them any more.
-rw-r--r--Library/Homebrew/dev-cmd/audit.rb4
1 files changed, 4 insertions, 0 deletions
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index ba6c3f333..45ae9201a 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -1021,6 +1021,10 @@ class FormulaAuditor
problem ":tex is deprecated."
end
+ if line =~ /depends_on\s+['"].+['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/
+ problem "Formulae should vendor #{$1} modules rather than use `depends_on ... => :#{$1}#{$2}`."
+ end
+
# Commented-out depends_on
problem "Commented-out dep #{$1}" if line =~ /#\s*depends_on\s+(.+)\s*$/