diff options
| author | Jack Nagel | 2014-09-20 11:42:19 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-09-20 11:42:19 -0500 |
| commit | 058f557f6afeeca3f7a21ae91b6339a0fcb408fa (patch) | |
| tree | 887eace0af3bd2356670cf14c25219fd5fd3d4bc | |
| parent | a6a4cd4c917259910a79f712a142fd75b5764379 (diff) | |
| download | brew-058f557f6afeeca3f7a21ae91b6339a0fcb408fa.tar.bz2 | |
Stop invoking the editor through an interactive shell
This was added in d2ecfb9 / Homebrew/homebrew#12784 to fix a bug repotted in Homebrew/homebrew#12779, but
at that time we were invoking the editor via `system` rather than
`exec`.
Now we are using exec, and running it through an interactive shell seems
to cause other problems, for example, emacs does not suspend/resume
properly.
Fixes Homebrew/homebrew#32328.
| -rw-r--r-- | Library/Homebrew/utils.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/utils.rb b/Library/Homebrew/utils.rb index fa2f430e3..ede63b5f6 100644 --- a/Library/Homebrew/utils.rb +++ b/Library/Homebrew/utils.rb @@ -212,7 +212,7 @@ end def safe_exec cmd, *args # This buys us proper argument quoting and evaluation # of environment variables in the cmd parameter. - exec "/bin/sh", "-i", "-c", cmd + ' "$@"', "--", *args + exec "/bin/sh", "-c", "#{cmd} \"$@\"", "--", *args end # GZips the given paths, and returns the gzipped paths |