aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/ng/rootScope.js1
-rw-r--r--test/ng/rootScopeSpec.js47
2 files changed, 48 insertions, 0 deletions
diff --git a/src/ng/rootScope.js b/src/ng/rootScope.js
index 1bb12869..7a28efa3 100644
--- a/src/ng/rootScope.js
+++ b/src/ng/rootScope.js
@@ -353,6 +353,7 @@ function $RootScopeProvider(){
return function() {
arrayRemove(array, watcher);
+ lastDirtyWatch = null;
};
},
diff --git a/test/ng/rootScopeSpec.js b/test/ng/rootScopeSpec.js
index 78cf9aa5..e47111e2 100644
--- a/test/ng/rootScopeSpec.js
+++ b/test/ng/rootScopeSpec.js
@@ -405,6 +405,53 @@ describe('Scope', function() {
$rootScope.$apply('remove = true');
}).not.toThrow();
}));
+
+
+ it('should not mess up the digest loop if deregistration happens during digest', inject(
+ function($rootScope, log) {
+
+ // we are testing this due to regression #5525 which is related to how the digest loops lastDirtyWatch
+ // short-circuiting optimization works
+
+ // scenario: watch1 deregistering watch1
+ var scope = $rootScope.$new();
+ var deregWatch1 = scope.$watch(log.fn('watch1'), function() { deregWatch1(); log('watchAction1'); });
+ scope.$watch(log.fn('watch2'), log.fn('watchAction2'));
+ scope.$watch(log.fn('watch3'), log.fn('watchAction3'));
+
+ $rootScope.$digest();
+
+ expect(log).toEqual(['watch1', 'watchAction1', 'watch2', 'watchAction2', 'watch3', 'watchAction3',
+ 'watch2', 'watch3']);
+ scope.$destroy();
+ log.reset();
+
+
+ // scenario: watch1 deregistering watch2
+ scope = $rootScope.$new();
+ scope.$watch(log.fn('watch1'), function() { deregWatch2(); log('watchAction1'); });
+ var deregWatch2 = scope.$watch(log.fn('watch2'), log.fn('watchAction2'));
+ scope.$watch(log.fn('watch3'), log.fn('watchAction3'));
+
+ $rootScope.$digest();
+
+ expect(log).toEqual(['watch1', 'watchAction1', 'watch1', 'watch3', 'watchAction3',
+ 'watch1', 'watch3']);
+ scope.$destroy();
+ log.reset();
+
+
+ // scenario: watch2 deregistering watch1
+ scope = $rootScope.$new();
+ deregWatch1 = scope.$watch(log.fn('watch1'), log.fn('watchAction1'));
+ scope.$watch(log.fn('watch2'), function() { deregWatch1(); log('watchAction2'); });
+ scope.$watch(log.fn('watch3'), log.fn('watchAction3'));
+
+ $rootScope.$digest();
+
+ expect(log).toEqual(['watch1', 'watchAction1', 'watch2', 'watchAction2', 'watch3', 'watchAction3',
+ 'watch2', 'watch3']);
+ }));
});