diff options
| author | Vojta Jina | 2013-11-05 12:31:20 -0800 |
|---|---|---|
| committer | Igor Minar | 2013-11-07 22:03:19 -0800 |
| commit | 909cabd36d779598763cc358979ecd85bb40d4d7 (patch) | |
| tree | 3f59a30dc5c44df46a86af249b0538272b47c555 /xx | |
| parent | 36621402015485613888158dc7ba29f4ff92a7e2 (diff) | |
| download | angular.js-909cabd36d779598763cc358979ecd85bb40d4d7.tar.bz2 | |
fix($compile): make isolate scope truly isolate
Fixes issue with isolate scope leaking all over the place into other directives on the same element.
Isolate scope is now available only to the isolate directive that requested it and its template.
A non-isolate directive should not get the isolate scope of an isolate directive on the same element,
instead they will receive the original scope (which is the parent scope of the newly created isolate scope).
Paired with Tobias.
BREAKING CHANGE: Directives without isolate scope do not get the isolate scope from an isolate directive on the same element. If your code depends on this behavior (non-isolate directive needs to access state from within the isolate scope), change the isolate directive to use scope locals to pass these explicitly.
// before
<input ng-model="$parent.value" ng-isolate>
.directive('ngIsolate', function() {
return {
scope: {},
template: '{{value}}'
};
});
// after
<input ng-model="value" ng-isolate>
.directive('ngIsolate', function() {
return {
scope: {value: '=ngModel'},
template: '{{value}}
};
});
Closes #1924
Closes #2500
Diffstat (limited to 'xx')
| -rw-r--r-- | xx | 0 |
1 files changed, 0 insertions, 0 deletions
