diff options
| author | Igor Minar | 2013-01-21 22:00:15 -0800 |
|---|---|---|
| committer | Igor Minar | 2013-01-22 07:35:06 -0800 |
| commit | c7addd488677307c6d2b35c7656179fbe6d80999 (patch) | |
| tree | 1be49a5798c66c62afbc4d7752159a9e3572cc88 /test | |
| parent | 6df60aff527e1ae13815a14fe3994b471e623a5b (diff) | |
| download | angular.js-c7addd488677307c6d2b35c7656179fbe6d80999.tar.bz2 | |
fix(angular.equals): relax the comparison for undefined properties
in 5ae63fd3 the comparison was made consistent but strict, so that
angular.equals({}, {foo: undefined}) // always returns false
this turns out to cause issues for data that is being roundtripped via network
and serialized via JSON because JSON.stringify serializes {foo: undefined} as {}.
Since angular.equals() behaved like this before the 5ae63fd3 in 50% of the cases,
changing the behavior in this way should not introduce any significant issues.
Closes #1648
Diffstat (limited to 'test')
| -rw-r--r-- | test/AngularSpec.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/AngularSpec.js b/test/AngularSpec.js index f5638b9c..09bc902f 100644 --- a/test/AngularSpec.js +++ b/test/AngularSpec.js @@ -126,12 +126,12 @@ describe('angular', function() { expect(equals(['misko'], ['misko', 'adam'])).toEqual(false); }); - it('should ignore undefined member variables', function() { + it('should ignore undefined member variables during comparison', function() { var obj1 = {name: 'misko'}, obj2 = {name: 'misko', undefinedvar: undefined}; - expect(equals(obj1, obj2)).toBe(false); - expect(equals(obj2, obj1)).toBe(false); + expect(equals(obj1, obj2)).toBe(true); + expect(equals(obj2, obj1)).toBe(true); }); it('should ignore $ member variables', function() { |
