aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorCaitlin Potter2013-10-19 15:41:06 -0400
committerIgor Minar2013-12-05 17:14:05 -0800
commit2dbb6f9a54eb5ff5847eed11c85ac4cf119eb41c (patch)
treea75288d7f421c25d411ad392d504a18c68c2af23 /test
parent785a5fd7c182f39f4ae80d603c0098bc63ce41a4 (diff)
downloadangular.js-2dbb6f9a54eb5ff5847eed11c85ac4cf119eb41c.tar.bz2
fix(isElement): return boolean value rather than `truthy` value.
angular.isElement currently returns a truthy object/function, or false. This patch aims to correct this behaviour by casting the result of the isElement expression to a boolean value via double-negation. Closes #4519 Closes #4534
Diffstat (limited to 'test')
-rw-r--r--test/AngularSpec.js13
1 files changed, 13 insertions, 0 deletions
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
index 1b08a18e..36d4926e 100644
--- a/test/AngularSpec.js
+++ b/test/AngularSpec.js
@@ -1079,4 +1079,17 @@ describe('angular', function() {
}
});
+ describe('isElement', function() {
+ it('should return a boolean value', inject(function($compile, $document, $rootScope) {
+ var element = $compile('<p>Hello, world!</p>')($rootScope),
+ body = $document.find('body')[0],
+ expected = [false, false, false, false, false, false, false, true, true],
+ tests = [null, undefined, "string", 1001, {}, 0, false, body, element];
+ angular.forEach(tests, function(value, idx) {
+ var result = angular.isElement(value);
+ expect(typeof result).toEqual('boolean');
+ expect(result).toEqual(expected[idx]);
+ });
+ }));
+ });
});