diff options
| author | Vojta Jina | 2012-01-12 03:00:34 -0800 |
|---|---|---|
| committer | Vojta Jina | 2012-01-13 01:07:12 -0800 |
| commit | 15fd735793cffe89fdf9662275409cdcdb3e801a (patch) | |
| tree | ce5699ab3375d41cfcffb88ed93236b7ff96a366 /test/widgetsSpec.js | |
| parent | 985d3d75586a16020d78564753f9b46ec9091929 (diff) | |
| download | angular.js-15fd735793cffe89fdf9662275409cdcdb3e801a.tar.bz2 | |
refactor($autoScroll): rename to $anchorScroll and allow disabling auto scrolling (links)
Now, that we have autoscroll attribute on ng:include, there is no reason to disable the service completely, so $anchorScrollProvider.disableAutoScrolling() means it won't be scrolling when $location.hash() changes.
And then, it's not $autoScroll at all, it actually scrolls to anchor when it's called, so I renamed
it to $anchorScroll.
Diffstat (limited to 'test/widgetsSpec.js')
| -rw-r--r-- | test/widgetsSpec.js | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/test/widgetsSpec.js b/test/widgetsSpec.js index 753a36b4..f119174f 100644 --- a/test/widgetsSpec.js +++ b/test/widgetsSpec.js @@ -225,10 +225,10 @@ describe('widget', function() { describe('autoscoll', function() { var autoScrollSpy; - function spyOnAutoScroll() { + function spyOnAnchorScroll() { return function($provide) { - autoScrollSpy = jasmine.createSpy('$autoScroll'); - $provide.value('$autoScroll', autoScrollSpy); + autoScrollSpy = jasmine.createSpy('$anchorScroll'); + $provide.value('$anchorScroll', autoScrollSpy); }; } @@ -247,20 +247,20 @@ describe('widget', function() { }; } - beforeEach(module(spyOnAutoScroll())); + beforeEach(module(spyOnAnchorScroll())); beforeEach(inject( putIntoCache('template.html', 'CONTENT'), putIntoCache('another.html', 'CONTENT'))); - it('should call $autoScroll if autoscroll attribute is present', inject( + it('should call $anchorScroll if autoscroll attribute is present', inject( compileAndLink('<ng:include src="tpl" autoscroll></ng:include>'), changeTplAndValueTo('template.html'), function() { expect(autoScrollSpy).toHaveBeenCalledOnce(); })); - it('should call $autoScroll if autoscroll evaluates to true', inject( + it('should call $anchorScroll if autoscroll evaluates to true', inject( compileAndLink('<ng:include src="tpl" autoscroll="value"></ng:include>'), changeTplAndValueTo('template.html', true), changeTplAndValueTo('another.html', 'some-string'), @@ -270,14 +270,14 @@ describe('widget', function() { })); - it('should not call $autoScroll if autoscroll attribute is not present', inject( + it('should not call $anchorScroll if autoscroll attribute is not present', inject( compileAndLink('<ng:include src="tpl"></ng:include>'), changeTplAndValueTo('template.html'), function() { expect(autoScrollSpy).not.toHaveBeenCalled(); })); - it('should not call $autoScroll if autoscroll evaluates to false', inject( + it('should not call $anchorScroll if autoscroll evaluates to false', inject( compileAndLink('<ng:include src="tpl" autoscroll="value"></ng:include>'), changeTplAndValueTo('template.html', false), changeTplAndValueTo('template.html', undefined), |
