Rename angular.foreach to angular.forEach to make the api consistent.

camelcase is used for other angular functions and forEach is also
used by EcmaScript standard.

- rename the internal as well as the external function name
- tweak the implementation of the function so that it doesn't
  clober it self when we extend the angular object with an
  object that has a forEach property equal to this forEach function

Closes #85

3 files changed, 5 insertions, 5 deletions

diff --git a/test/scenario/RunnerSpec.js b/test/scenario/RunnerSpec.js
index 059dd874..5ebe5690 100644
--- a/test/scenario/RunnerSpec.js
+++ b/test/scenario/RunnerSpec.js
@@ -54,7 +54,7 @@ describe('angular.scenario.Runner', function() {
   });
 
   it('should publish the functions in the public API', function() {
-    angular.foreach(runner.api, function(fn, name) {
+    angular.forEach(runner.api, function(fn, name) {
       var func;
       if (name in $window) {
         func = $window[name];
diff --git a/test/scenario/dslSpec.js b/test/scenario/dslSpec.js
index 6551b6fc..71dfde3c 100644
--- a/test/scenario/dslSpec.js
+++ b/test/scenario/dslSpec.js
@@ -28,7 +28,7 @@ describe("angular.scenario.dsl", function() {
       });
     };
     $root.dsl = {};
-    angular.foreach(angular.scenario.dsl, function(fn, name) {
+    angular.forEach(angular.scenario.dsl, function(fn, name) {
       $root.dsl[name] = function() {
         return fn.call($root).apply($root, arguments);
       };
@@ -281,7 +281,7 @@ describe("angular.scenario.dsl", function() {
       it('should add all jQuery key/value methods', function() {
         var METHODS = ['css', 'attr'];
         var chain = $root.dsl.element('input');
-        angular.foreach(METHODS, function(name) {
+        angular.forEach(METHODS, function(name) {
           expect(angular.isFunction(chain[name])).toBeTruthy();
         });
       });
@@ -316,7 +316,7 @@ describe("angular.scenario.dsl", function() {
           'innerWidth', 'outerWidth', 'position', 'scrollLeft', 'scrollTop', 'offset'
         ];
         var chain = $root.dsl.element('input');
-        angular.foreach(METHODS, function(name) {
+        angular.forEach(METHODS, function(name) {
           expect(angular.isFunction(chain[name])).toBeTruthy();
         });
       });
diff --git a/test/scenario/mocks.js b/test/scenario/mocks.js
index 5cd2f30a..616e5d63 100644
--- a/test/scenario/mocks.js
+++ b/test/scenario/mocks.js
@@ -35,7 +35,7 @@ angular.scenario.testing.MockRunner.prototype.on = function(eventName, fn) {
   
 angular.scenario.testing.MockRunner.prototype.emit = function(eventName) {
   var args = Array.prototype.slice.call(arguments, 1);
-  angular.foreach(this.listeners[eventName] || [], function(fn) {
+  angular.forEach(this.listeners[eventName] || [], function(fn) {
     fn.apply(this, args);
   });
 };