aboutsummaryrefslogtreecommitdiffstats
path: root/test/ng/directive/aSpec.js
diff options
context:
space:
mode:
authorKarl Seamon2013-12-09 15:36:15 -0500
committerIgor Minar2013-12-13 00:31:25 -0800
commitf3de5b6eac90baf649506072162f36dbc6d2f028 (patch)
treee96b658664e7786658e537abc40dc580c22e557e /test/ng/directive/aSpec.js
parentfcd2a8131a3cb3e59a616bf31e61510b5c3a97d3 (diff)
downloadangular.js-f3de5b6eac90baf649506072162f36dbc6d2f028.tar.bz2
perf(a): do not link when href or name exists in template
Change the a directive to link and hookup a click event only when there is no href or name in the template element. In a large Google app, this results in about 800 fewer registrations, saving a small but measurable amount of time and memory. Closes #5362
Diffstat (limited to 'test/ng/directive/aSpec.js')
-rw-r--r--test/ng/directive/aSpec.js26
1 files changed, 26 insertions, 0 deletions
diff --git a/test/ng/directive/aSpec.js b/test/ng/directive/aSpec.js
index a284f4bc..dc0de729 100644
--- a/test/ng/directive/aSpec.js
+++ b/test/ng/directive/aSpec.js
@@ -58,4 +58,30 @@ describe('a', function() {
expect(element.text()).toBe('hello@you');
});
+
+
+ it('should not link and hookup an event if href is present at compile', function() {
+ var jq = jQuery || jqLite;
+ element = jq('<a href="//a.com">hello@you</a>');
+ var linker = $compile(element);
+
+ spyOn(jq.prototype, 'on');
+
+ linker($rootScope);
+
+ expect(jq.prototype.on).not.toHaveBeenCalled();
+ });
+
+
+ it('should not link and hookup an event if name is present at compile', function() {
+ var jq = jQuery || jqLite;
+ element = jq('<a name="bobby">hello@you</a>');
+ var linker = $compile(element);
+
+ spyOn(jq.prototype, 'on');
+
+ linker($rootScope);
+
+ expect(jq.prototype.on).not.toHaveBeenCalled();
+ });
});