diff options
| author | Hubert SABLONNIÈRE | 2013-10-25 21:52:49 +0200 | 
|---|---|---|
| committer | Tobias Bosch | 2013-12-03 09:45:06 -0800 | 
| commit | 1169b5445691e1495354d235a3badf05240e3904 (patch) | |
| tree | b901dd059e234cfb38bcc9d655e9c6c37446cf9f /test/jqLiteSpec.js | |
| parent | 81b81856ee43d2876927c4e1f774affa87e99707 (diff) | |
| download | angular.js-1169b5445691e1495354d235a3badf05240e3904.tar.bz2 | |
fix(jqLite): ignore incompatible nodes on find()
When a jqLite collection contains text nodes, find() does not work :-(
This fix ignores all nodes than can't do getElementsByTagName()
It seems a little bit faster than testing nodeType : http://jsperf.com/nodetype-vs-duck-typing
Closes #4120
Diffstat (limited to 'test/jqLiteSpec.js')
| -rw-r--r-- | test/jqLiteSpec.js | 6 | 
1 files changed, 6 insertions, 0 deletions
| diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index 02a17df8..09be1c1c 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -1335,6 +1335,12 @@ describe('jqLite', function() {        expect(innerDiv.length).toEqual(1);        expect(innerDiv.html()).toEqual('text');      }); + +    it('should find child by name and not care about text nodes', function() { +      var divs = jqLite('<div><span>aa</span></div>text<div><span>bb</span></div>'); +      var innerSpan = divs.find('span'); +      expect(innerSpan.length).toEqual(2); +    });    }); | 
