aboutsummaryrefslogtreecommitdiffstats
path: root/test/AngularSpec.js
diff options
context:
space:
mode:
authorCodier2011-11-15 18:45:36 -0600
committerIgor Minar2011-11-21 15:43:12 -0800
commit29f9e2665d8b771a6226870fc8fd2c4c94d7a2c0 (patch)
treec48f91fea9b97b10b13d4e1ec636e6cd7995578e /test/AngularSpec.js
parent8d1944851d5bbecd9277ede8c4a354c2d43796ee (diff)
downloadangular.js-29f9e2665d8b771a6226870fc8fd2c4c94d7a2c0.tar.bz2
fix(scope): $watch (and angular.equals) should support NaN values
- since NaN !== NaN in javascript digest can get into an infinite loop when model value is set to NaN - angular.equals(NaN, NaN) should return true since that's what we expect when comparing primitives or objects containing NaN values Previously NaN because of its special === properties was used as the initial value for watches, but that results in issues when NaN is used as model value. In order to allow for model to be anything incuding undefined and NaN we need to mark the initial value differently in a way that would avoid these issues, allow us to run digest without major perf penalties and allow for clients to determine if the listener is being called because the watcher is being initialized or because the model changed. This implementation covers all of these scenarios. BREAKING CHANGE: previously to detect if the listener was called because the watcher was being initialized, it was suggested that clients check if old value is NaN. With this change, the check should be if the newVal equals the oldVal. Closes #657
Diffstat (limited to 'test/AngularSpec.js')
-rw-r--r--test/AngularSpec.js4
1 files changed, 4 insertions, 0 deletions
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
index 81a4901b..53f62f00 100644
--- a/test/AngularSpec.js
+++ b/test/AngularSpec.js
@@ -110,6 +110,10 @@ describe('angular', function() {
expect(equals(undefined, undefined)).toBe(true);
});
+
+ it('should treat two NaNs as equal', function() {
+ expect(equals(NaN, NaN)).toBe(true);
+ });
});
describe('size', function() {