style(*): wrap all assignments in if statements

we commonly assign stuff in if statments like this:

if (variable = someFn()) {
  //do something with variable
}

This results in lint and IDE warnings (did you mean ==?).

It is better to be explicit about our intention and wrap the assignement
into parens:

if ((variable = someFn())) {
  //do something with variable
}

Doing so suppresses warnings + is easier to understand the intention.

I verified that the closure compiler strips the extra parens, so there
is no byte overhead for this safety practice.

We should use this style going forward...

1 files changed, 2 insertions, 2 deletions

diff --git a/src/widgets.js b/src/widgets.js
index d9af21c9..30f7256a 100644
--- a/src/widgets.js
+++ b/src/widgets.js
@@ -877,7 +877,7 @@ angularWidget('select', function(element){
           lastElement = null;  // start at the begining
           for(index = 0, length = optionGroup.length; index < length; index++) {
             option = optionGroup[index];
-            if (existingOption = existingOptions[index+1]) {
+            if ((existingOption = existingOptions[index+1])) {
               // reuse elements
               lastElement = existingOption.element;
               if (existingOption.label !== option.label) {
@@ -1116,7 +1116,7 @@ angularWidget('ng:switch', function (element) {
 
     this.$watch(watchExpr, function(scope, value) {
       element.html('');
-      if (selectedTemplate = casesTemplate[value] || defaultCaseTemplate) {
+      if ((selectedTemplate = casesTemplate[value] || defaultCaseTemplate)) {
         changeCounter++;
         if (childScope) childScope.$destroy();
         childScope = scope.$new();