diff options
| author | Vojta Jina | 2011-05-31 14:51:47 +0200 |
|---|---|---|
| committer | Igor Minar | 2011-06-02 11:15:41 -0700 |
| commit | 4b0f2dfe0cbd4b5348af8cfb5af2e40904c73a47 (patch) | |
| tree | bfe098ad61c01898a6f7138d9b6baa82345e68c9 /src/widgets.js | |
| parent | dad26037521ff681f9a3c3d4a9bebf14fb8e38cc (diff) | |
| download | angular.js-4b0f2dfe0cbd4b5348af8cfb5af2e40904c73a47.tar.bz2 | |
Fix IE bug - ng:href
ng:href was producing unclickable links, as the event propagation was stopped by 'a' widget
All links in regression/issue-352.html were tested in:
* Chrome 11
* Opera 11
* Firefox 4
* IE7, IE8
Closes #352
Diffstat (limited to 'src/widgets.js')
| -rw-r--r-- | src/widgets.js | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/widgets.js b/src/widgets.js index 6aa0227c..a56a967e 100644 --- a/src/widgets.js +++ b/src/widgets.js @@ -821,7 +821,15 @@ angularWidget('a', function() { this.directives(true); return function(element) { - if (element.attr('href') === '') { + var hasNgHref = ((element.attr('ng:bind-attr') || '').indexOf('"href":') !== -1); + + // turn <a href ng:click="..">link</a> into a link in IE + // but only if it doesn't have name attribute, in which case it's an anchor + if (!hasNgHref && !element.attr('name') && !element.attr('href')) { + element.attr('href', ''); + } + + if (element.attr('href') === '' && !hasNgHref) { element.bind('click', function(event){ event.preventDefault(); }); |
