style(*): wrap all assignments in if statements

we commonly assign stuff in if statments like this:

if (variable = someFn()) {
  //do something with variable
}

This results in lint and IDE warnings (did you mean ==?).

It is better to be explicit about our intention and wrap the assignement
into parens:

if ((variable = someFn())) {
  //do something with variable
}

Doing so suppresses warnings + is easier to understand the intention.

I verified that the closure compiler strips the extra parens, so there
is no byte overhead for this safety practice.

We should use this style going forward...

1 files changed, 1 insertions, 1 deletions

diff --git a/src/service/route.js b/src/service/route.js
index 9b4db0dd..5741c940 100644
--- a/src/service/route.js
+++ b/src/service/route.js
@@ -216,7 +216,7 @@ angularServiceInject('$route', function($location) {
     // Match a route
     forEach(routes, function(rParams, rPath) {
       if (!pathParams) {
-        if (pathParams = matcher($location.hashPath, rPath)) {
+        if ((pathParams = matcher($location.hashPath, rPath))) {
           selectedRoute = rParams;
         }
       }