style(*): wrap all assignments in if statements

we commonly assign stuff in if statments like this:

if (variable = someFn()) {
  //do something with variable
}

This results in lint and IDE warnings (did you mean ==?).

It is better to be explicit about our intention and wrap the assignement
into parens:

if ((variable = someFn())) {
  //do something with variable
}

Doing so suppresses warnings + is easier to understand the intention.

I verified that the closure compiler strips the extra parens, so there
is no byte overhead for this safety practice.

We should use this style going forward...

1 files changed, 1 insertions, 1 deletions

diff --git a/src/directives.js b/src/directives.js
index 937d0cca..54d7feb2 100644
--- a/src/directives.js
+++ b/src/directives.js
@@ -230,7 +230,7 @@ angularDirective("ng:bind", function(expression, element){
       // If we are HTML than save the raw HTML data so that we don't
       // recompute sanitization since it is expensive.
       // TODO: turn this into a more generic way to compute this
-      if (isHtml = (value instanceof HTML))
+      if ((isHtml = (value instanceof HTML)))
         value = (html = value).html;
       if (lastValue === value && lastError == error) return;
       isDomElement = isElement(value);